From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel@vger.kernel.org, Rui Prior <rprior@inescn.pt>,
akpm@osdl.org
Subject: Re: [PATCH] atm/nicstar: remove a bunch of pointless casts of NULL
Date: Wed, 11 May 2005 00:58:12 +0400 [thread overview]
Message-ID: <200505110058.12932.adobriyan@mail.ru> (raw)
In-Reply-To: <Pine.LNX.4.62.0505102203170.2386@dragon.hyggekrogen.localhost>
On Wednesday 11 May 2005 00:06, Jesper Juhl wrote:
> It doesn't make sense to cast NULL. This patch removes the pointless casts
> from drivers/atm/nicstar.c
> --- linux-2.6.12-rc3-mm3-orig/drivers/atm/nicstar.c
> +++ linux-2.6.12-rc3-mm3/drivers/atm/nicstar.c
> scq = (scq_info *) kmalloc(sizeof(scq_info), GFP_KERNEL);
^^^^^^^^^^^^
> - if (scq == (scq_info *) NULL)
> - return (scq_info *) NULL;
> + if (scq == NULL)
> + return NULL;
> scq->skb = (struct sk_buff **) kmalloc(sizeof(struct sk_buff *) *
^^^^^^^^^^^^^^^^^^^
> (size / NS_SCQE_SIZE), GFP_KERNEL);
> - if (scq->skb == (struct sk_buff **) NULL)
> + if (scq->skb == NULL)
These are pointless too.
next prev parent reply other threads:[~2005-05-10 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 20:06 Jesper Juhl
2005-05-10 20:58 ` Alexey Dobriyan [this message]
2005-05-10 21:02 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505110058.12932.adobriyan@mail.ru \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=rprior@inescn.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®