From: Matthew Wilcox <matthew@wil.cx>
To: cotte@freenet.de
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
schwidefsky@de.ibm.com, akpm@osdl.org
Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support
Date: Wed, 11 May 2005 18:50:50 +0100 [thread overview]
Message-ID: <20050511175050.GE10567@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <428216F7.30303@de.ibm.com>
On Wed, May 11, 2005 at 04:30:15PM +0200, Carsten Otte wrote:
> + BUG_ON(!mapping->a_ops->get_xip_page);
No need to put this assert here. You'll get exactly as good a stack trace ...
> + page = mapping->a_ops->get_xip_page(mapping,
> + index*(PAGE_SIZE/512), 0);
... here, when you call through a null pointer.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
prev parent reply other threads:[~2005-05-11 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 14:30 Carsten Otte
2005-05-11 15:09 ` Christoph Hellwig
2005-05-11 15:33 ` Carsten Otte
2005-05-11 15:47 ` Badari Pulavarty
2005-05-11 16:19 ` Carsten Otte
2005-05-11 17:31 ` Arnd Bergmann
2005-05-11 17:47 ` Carsten Otte
2005-05-11 17:50 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050511175050.GE10567@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=cotte@freenet.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®