From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org, ak@suse.de, tripperda@nvidia.com
Subject: Re: [RFC] Cachemap for 2.6.12rc4-mm1. Was Re: [PATCH] enhance x86 MTRR handling
Date: Fri, 13 May 2005 15:29:45 +0200 [thread overview]
Message-ID: <20050513132945.GB16088@wotan.suse.de> (raw)
In-Reply-To: <20050512214118.GA25065@redhat.com>
> : x86-64 will need updating to also take advantage of this.
> It may be able to just copy the i386 includes as-is, I've
> not looked closely at the PAT related changes on x86-64 yet. Andi?
>
> : The list manipulation macros in mm/cachemap.c are a little fugly.
>
> Anything else ?
For memory (pfn_valid == 1) it would be more memory efficient to use a few bits
in struct page->flags
In general because there are lots of uses of "range lists" it would be better
to put it as a library into lib.
Coding style needs some work.
Too many printks.
I am not sure yet the cmaps don't need reference counting. For some
cases (user space support) they probably will.
Need user space support, e.g. using the existing ioctls for /proc/bus/pci/*
(they are currently not implemented on i386/x86-64 but should with this)
Then someone would need to change the X server to use this.
Needs testing on a lot of systems.
Need to figure out if CMAP_ALLOW_OVERLAPPING should be set or not.
Probably need to go over the combining rule etc. with a fine comb
-Andi
next prev parent reply other threads:[~2005-05-13 13:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 9:08 Jan Beulich
2005-05-12 16:18 ` Dave Jones
2005-05-12 17:02 ` David Addison
2005-05-12 21:41 ` [RFC] Cachemap for 2.6.12rc4-mm1. Was " Dave Jones
2005-05-13 13:29 ` Andi Kleen [this message]
2005-05-13 14:24 ` Dave Hansen
2005-05-13 14:35 ` Andi Kleen
2005-05-13 15:52 ` Dave Jones
2005-05-18 22:01 ` Terence Ripperda
2005-05-18 22:03 ` Andi Kleen
2005-05-18 22:15 ` Terence Ripperda
2005-05-18 22:42 ` Andi Kleen
2005-05-19 3:57 ` Randy Dunlap
2005-05-13 22:40 ` H. Peter Anvin
2005-05-13 23:23 ` Dave Jones
2005-05-13 23:36 ` H. Peter Anvin
2005-05-13 23:42 ` Dave Jones
2005-05-13 23:49 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050513132945.GB16088@wotan.suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tripperda@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®