From: Tejun Heo <htejun@gmail.com>
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH scsi-misc-2.6 00/03] scsi: misc timer fixes (again)
Date: Sat, 14 May 2005 09:46:03 +0900 (KST) [thread overview]
Message-ID: <20050514004601.783910E3@htj.dyndns.org> (raw)
Hello, James.
It's been a while, but I'm finally settled with git. :-)
This is repost of the previous scsi timer patchset. After thinking
about it a while, the first patch seemed unnecessary as you told, so
it's dropped and the others are regenerated.
aic79xx_osm.c DV still uses eh_timeout. Is it gonna be updated like
aic7xxx_osm.c is updated? If not, I have a patch to fix the eh timer
part. I have a patcheset waiting for it to be clared - unexporting
SCSI timer as the semantics is very specific and nothing good can come
from tempering with it. Once aic79xx_osm.c is cleared, I'll post the
patches.
[ Start of patch descriptions ]
01_scsi_timer_dispatch_race_fix.patch
: remove a timer race in scsi_queue_insert()
scsi_queue_insert() has four callers. Three callers call with
timer disabled and one (the second invocation in
scsi_dispatch_cmd()) calls with timer activated.
scsi_queue_insert() used to always call scsi_delete_timer()
and ignore the return value. This results in race with timer
expiration. Remove scsi_delete_timer() call from
scsi_queue_insert() and make the caller delete timer and check
the return value.
02_scsi_timer_remove_delete_timer_from_reset_provider.patch
: remove unnecessary scsi_delete_timer() call in scsi_reset_provider()
scsi_reset_provider() calls scsi_delete_timer() on exit which
isn't necessary. Remove it.
03_scsi_timer_eh_timer_remove_spurious_if.patch
: remove spurious if tests from scsi_eh_{times_out|done}
'if' tests which check if eh_action isn't NULL in both
functions are always true. Remove the redundant if's as it
can give wrong impressions.
[ End of patch descriptions ]
Thanks.
next reply other threads:[~2005-05-14 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-14 0:46 Tejun Heo [this message]
2005-05-14 0:46 ` [PATCH scsi-misc-2.6 01/03] scsi: remove a timer race in scsi_queue_insert() Tejun Heo
2005-05-14 0:46 ` [PATCH scsi-misc-2.6 02/03] scsi: remove unnecessary scsi_delete_timer() call in scsi_reset_provider() Tejun Heo
2005-05-14 0:46 ` [PATCH scsi-misc-2.6 03/03] scsi: remove spurious if tests from scsi_eh_{times_out|done} Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050514004601.783910E3@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®