Re: serial console

[Andrew Morton <akpm@osdl.org>]

Matt Mackall <mpm@selenic.com> wrote:
>
> Fix compile bug with serial console and printk disabled.
> 
> Signed-off-by: Matt Mackall <mpm@selenic.com>
> 
> Index: l-p/kernel/printk.c
> ===================================================================
> --- l-p.orig/kernel/printk.c	2005-05-16 15:13:51.000000000 -0700
> +++ l-p/kernel/printk.c	2005-05-16 15:29:56.000000000 -0700
> @@ -665,6 +665,11 @@ asmlinkage long sys_syslog(int type, cha
>  	return 0;
>  }
>  
> +int __init add_preferred_console(char *name, int idx, char *options)
> +{
> +	return 0;
> +}
> +

It would be nicer if this was a static inline, so all the function call
code at the callsites is removed by the compiler.

Yes, it's presumably __init code anyway, but that's no excuse ;)