From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Greg K-H <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, petero2@telia.com
Subject: Re: [PATCH] Fix root hole in pktcdvd
Date: Tue, 17 May 2005 06:00:25 +0100 [thread overview]
Message-ID: <20050517050025.GP1150@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <11163046692974@kroah.com>
On Mon, May 16, 2005 at 09:37:49PM -0700, Greg KH wrote:
> ioctl_by_bdev may only be used INSIDE the kernel. If the "arg" argument
> refers to memory that is accessed by put_user/get_user in the ioctl
> function, the memory needs to be in the kernel address space (that's the
> set_fs(KERNEL_DS) doing in the ioctl_by_bdev). This works on i386 because
> even with set_fs(KERNEL_DS) the user space memory is still accessible with
> put_user/get_user. That is not true for s390. In short the ioctl
> implementation of the pktcdvd device driver is horribly broken.
Same comment as for previous patch. I'll take a look at that sucker,
it might happen to be OK, seeing that most of the bdev ->ioctl() instances
ignore file argument and we might get away with passing odd stuff to
anything that could occur here.
next prev parent reply other threads:[~2005-05-17 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 4:37 [GIT PATCH] Stable bugfixes for 2.6.12-rc4 Greg KH
2005-05-17 4:37 ` [PATCH] fix Linux kernel ELF core dump privilege elevation Greg KH
2005-05-17 4:37 ` [PATCH] Fix root hole in raw device Greg KH
2005-05-17 4:37 ` [PATCH] Fix root hole in pktcdvd Greg KH
2005-05-17 5:00 ` Al Viro [this message]
2005-05-17 5:54 ` Al Viro
2005-05-17 18:12 ` Peter Osterlund
2005-05-17 15:35 ` Greg KH
2005-05-17 4:57 ` [PATCH] Fix root hole in raw device Al Viro
2005-05-17 7:03 ` Willy Tarreau
2005-05-17 7:07 ` Willy Tarreau
2005-05-17 7:38 ` Al Viro
2005-05-17 7:32 ` Al Viro
2005-05-17 13:04 ` Stephen C. Tweedie
2005-05-17 16:53 ` Al Viro
2005-05-22 11:55 ` Peter Osterlund
2005-05-22 11:57 ` Peter Osterlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050517050025.GP1150@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome