From: Pete Zaitcev <zaitcev@redhat.com>
To: "Pozsár Balázs" <pozsy@uhulinux.hu>
Cc: bzolnier@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
zaitcev@redhat.com
Subject: Re: Oops on CF removal and "convert device drivers to driver-model"
Date: Tue, 17 May 2005 14:51:37 -0700 [thread overview]
Message-ID: <20050517145137.6b91f242.zaitcev@redhat.com> (raw)
In-Reply-To: <20050517211704.GB7452@ojjektum.uhulinux.hu>
On Tue, 17 May 2005 23:17:04 +0200, Pozsár Balázs <pozsy@uhulinux.hu> wrote:
> On Sat, May 14, 2005 at 01:50:19PM -0700, Pete Zaitcev wrote:
> > @@ -1138,7 +1133,8 @@ static int idescsi_attach(ide_drive_t *d
> > idescsi->host = host;
> > idescsi->disk = g;
> > g->private_data = &idescsi->driver;
> > - err = ide_register_subdriver(drive, &idescsi_driver);
> > + ide_register_subdriver(drive, &idescsi_driver);
> > + err = 0;
> > if (!err) {
> > idescsi_setup (drive, idescsi);
> > g->fops = &idescsi_ops;
>
> !err cannot be true here, so this seems buggy.
Indeed.
Unfortunately, Andrew's scripts notified me that he added the patch to
his tree, so I'd need to wait for a turnaround before a fix-over-fix.
-- Pete
next prev parent reply other threads:[~2005-05-17 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-14 20:50 Pete Zaitcev
2005-05-17 21:17 ` Pozsár Balázs
2005-05-17 21:51 ` Pete Zaitcev [this message]
2005-05-18 7:14 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050517145137.6b91f242.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=bzolnier@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=pozsy@uhulinux.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®