mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Alexander Nyberg <alexn@telia.com>
Cc: fastboot@lists.osdl.org,
	linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Morton Andrew Morton <akpm@osdl.org>
Subject: Re: [Fastboot] [2/2] kdump: Save trap information for later analyzis
Date: Wed, 18 May 2005 18:11:44 +0530	[thread overview]
Message-ID: <20050518124144.GB3657@in.ibm.com> (raw)
In-Reply-To: <1116103800.6153.31.camel@localhost.localdomain>

On Sat, May 14, 2005 at 10:50:00PM +0200, Alexander Nyberg wrote:
> If we are faulting in kernel it is quite possible this will lead to a
> panic. Save trap number, cr2 (in case of page fault) and error_code in
> the current thread (these fields already exist for signal delivery but
> are not used here). 
> 
> This helps later kdump crash analyzing from user-space (a script has
> been submitted to dig this info out in gdb).
> 
> Signed-off-by: Alexander Nyberg <alexn@telia.com>
> 
> Index: mm/arch/i386/mm/fault.c
> ===================================================================
> --- mm.orig/arch/i386/mm/fault.c	2005-05-14 22:05:56.000000000 +0200
> +++ mm/arch/i386/mm/fault.c	2005-05-14 22:06:21.000000000 +0200
> @@ -469,6 +469,9 @@
>  		printk(KERN_ALERT "*pte = %08lx\n", page);
>  	}
>  #endif
> +	tsk->thread.cr2 = address;
> +	tsk->thread.trap_no = 14;
> +	tsk->thread.error_code = error_code;
>  	die("Oops", regs, error_code);
>  	bust_spinlocks(0);
>  	do_exit(SIGKILL);
> Index: mm/arch/i386/kernel/traps.c
> ===================================================================
> --- mm.orig/arch/i386/kernel/traps.c	2005-05-14 22:05:56.000000000 +0200
> +++ mm/arch/i386/kernel/traps.c	2005-05-14 22:06:21.000000000 +0200
> @@ -431,8 +431,11 @@
>  	}
>  
>  	kernel_trap: {
> -		if (!fixup_exception(regs))
> +		if (!fixup_exception(regs)) {
> +			current->thread.trap_no = trapnr;
> +			current->thread.error_code = error_code;
>  			die(str, regs, error_code);
> +		}
>  		return;
>  	}
>  
> @@ -537,6 +540,9 @@
>  	}
>  	put_cpu();
>  
> +	current->thread.error_code = error_code;
> +	current->thread.trap_no = 13;
> +	


This assignment is being done again in case thread was running in user mode.
That can now be done away with as above code will take care of both the cases.

	if (!user_mode(regs))
		goto gp_in_kernel;

	current->thread.error_code = error_code;
	current->thread.trap_no = 13;
	force_sig(SIGSEGV, current);



>  	if (regs->eflags & VM_MASK)
>  		goto gp_in_vm86;
>  
> @@ -977,9 +983,9 @@
>  					  error_code);
>  			return;
>  		}
> -		die_if_kernel("cache flush denied", regs, error_code);
>  		current->thread.trap_no = 19;
>  		current->thread.error_code = error_code;
> +		die_if_kernel("cache flush denied", regs, error_code);
>  		force_sig(SIGSEGV, current);
>  	}
>  }
> 
> 

> _______________________________________________
> fastboot mailing list
> fastboot@lists.osdl.org
> http://lists.osdl.org/mailman/listinfo/fastboot


       reply	other threads:[~2005-05-18 12:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1116103800.6153.31.camel@localhost.localdomain>
2005-05-18 12:41 ` Vivek Goyal [this message]
2005-05-18 14:51   ` Alexander Nyberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050518124144.GB3657@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=alexn@telia.com \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®