From: Christoph Hellwig <hch@infradead.org>
To: Russell Miller <rmiller@duskglow.com>, marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.30 xfs bug
Date: Wed, 18 May 2005 15:09:58 +0100 [thread overview]
Message-ID: <20050518140958.GA22771@infradead.org> (raw)
In-Reply-To: <200505121117.01192.rmiller@duskglow.com>
On Thu, May 12, 2005 at 11:17:01AM -0700, Russell Miller wrote:
> 2.4.30 will not compile if XFS is turned on, but XFS debugging is not.
> Culprit is:
>
> fs/xfs/linux-2.4/xfs_buf.c line 1076. Apparently pagebuf_lock_value is used
> somewhere else, even if it's not defined because debugging is off.
Looks like a trivial one-liner got lost when merging from the SGI CVS tree.
Macelo, can you apply this little patch below?
--- 1.195/fs/xfs/linux-2.4/xfs_buf.c 2005-01-12 01:08:23 +01:00
+++ edited/fs/xfs/linux-2.4/xfs_buf.c 2005-05-18 16:06:09 +02:00
@@ -1073,7 +1073,7 @@ pagebuf_cond_lock( /* lock buffer, if
return(locked ? 0 : -EBUSY);
}
-#ifdef DEBUG
+#if defined(DEBUG) || defined(XFS_BLI_TRACE)
/*
* pagebuf_lock_value
*
prev parent reply other threads:[~2005-05-18 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 18:17 Russell Miller
2005-05-18 14:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518140958.GA22771@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=rmiller@duskglow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®