From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Corey Minyard <minyard@acm.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, jordan_hargrave@dell.com
Subject: Re: [PATCH] Add 32-bit ioctl translations for 64-bit platforms
Date: Fri, 20 May 2005 14:33:37 +1000 [thread overview]
Message-ID: <20050520143337.38b6b5a6.sfr@canb.auug.org.au> (raw)
In-Reply-To: <428D2241.5070005@acm.org>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
Hi Cory,
On Thu, 19 May 2005 18:33:21 -0500 Corey Minyard <minyard@acm.org> wrote:
>
> +struct ipmi_msg32
> +{
> + uint8_t netfn;
> + uint8_t cmd;
> + uint16_t data_len;
> + compat_uptr_t data;
> +};
Why are you using unint8_t etc when we have perfectly good kernel types u8
etc?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-05-20 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 23:33 Corey Minyard
2005-05-20 4:33 ` Stephen Rothwell [this message]
2005-05-20 13:57 ` Corey Minyard
2005-05-20 21:22 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050520143337.38b6b5a6.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@osdl.org \
--cc=jordan_hargrave@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®