From: Pavel Machek <pavel@ucw.cz>
To: Henrik Brix Andersen <brix@gentoo.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: pm_message_t fix for radeon_pm.c
Date: Sun, 22 May 2005 12:50:50 +0200 [thread overview]
Message-ID: <20050522105050.GA3685@elf.ucw.cz> (raw)
In-Reply-To: <1116669744.14475.7.camel@sponge.fungus>
On So 21-05-05 12:02:24, Henrik Brix Andersen wrote:
> This patch adds a missing .event to pm_message_t handling in
> drivers/video/aty/radeon_pm.c for linux-2.6.12-rc4.
>
> --- linux-2.6.12-rc4/drivers/video/aty/radeon_pm.c 2005-05-21 11:31:32.000000000 +0200
> +++ linux-2.6.12-rc4-radeon_pm/drivers/video/aty/radeon_pm.c 2005-05-21 11:34:51.000000000 +0200
> @@ -2526,11 +2526,11 @@ int radeonfb_pci_suspend(struct pci_dev
> struct radeonfb_info *rinfo = info->par;
> int i;
>
> - if (state == pdev->dev.power.power_state)
> + if (state.event == pdev->dev.power.power_state.event)
> return 0;
>
> printk(KERN_DEBUG "radeonfb (%s): suspending to state: %d...\n",
> - pci_name(pdev), state);
> + pci_name(pdev), state.event);
>
> /* For suspend-to-disk, we cheat here. We don't suspend anything and
> * let fbcon continue drawing until we are all set. That shouldn't
Are you sure? I think you'll _break_ compilation by doing
this. pm_message_t becoming struct is not yet merged in rc4, IIRC.
Pavel
next prev parent reply other threads:[~2005-05-22 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-21 10:02 Henrik Brix Andersen
2005-05-22 10:50 ` Pavel Machek [this message]
2005-05-22 10:54 ` Nigel Cunningham
2005-05-23 9:10 ` Pavel Machek
2005-05-22 11:26 ` Henrik Brix Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050522105050.GA3685@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=brix@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®