From: Ashok Raj <ashok.raj@intel.com>
To: Andi Kleen <ak@muc.de>
Cc: Ashok Raj <ashok.raj@intel.com>,
akpm@osdl.org, zwane@arm.linux.org.uk, rusty@rustycorp.com.au,
vatsa@in.ibm.com, shaohua.li@intel.com,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [patch 1/4] CPU Hotplug support for X86_64
Date: Tue, 24 May 2005 08:51:13 -0700 [thread overview]
Message-ID: <20050524085112.A20866@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050524121542.GA86182@muc.de>; from ak@muc.de on Tue, May 24, 2005 at 02:15:42PM +0200
On Tue, May 24, 2005 at 02:15:42PM +0200, Andi Kleen wrote:
> On Tue, May 24, 2005 at 01:11:14AM -0700, Ashok Raj wrote:
> > * RED-PEN audit/test this more. I bet there is more state messed up here.
> > */
> > -static __cpuinit void disable_smp(void)
> > +static __init void disable_smp(void)
>
> Why all these cpuinit->init changes? I think they should stay __cpuinit
>
> The other way round looks ok.
disable_smp() is called only in smp_prepare_cpus() which is not required
for hotplug. Its currently only required only for startup, and not later.
I changed the ones from __cpuinit to __init, just in functions marked
with paranoia... i think it can stay cpuinit, unless there is another reason
i didnt catch.
>
> -Andi
--
Cheers,
Ashok Raj
- Open Source Technology Center
next prev parent reply other threads:[~2005-05-24 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 8:11 [patch 0/4] " Ashok Raj
2005-05-24 8:11 ` [patch 1/4] " Ashok Raj
2005-05-24 12:15 ` Andi Kleen
2005-05-24 15:51 ` Ashok Raj [this message]
2005-05-24 18:18 ` Andi Kleen
2005-05-24 8:11 ` [patch 2/4] " Ashok Raj
2005-05-24 12:24 ` Andi Kleen
2005-05-24 8:11 ` [patch 3/4] " Ashok Raj
2005-05-24 12:27 ` Andi Kleen
2005-05-24 8:11 ` [patch 4/4] " Ashok Raj
2005-05-24 12:28 ` Andi Kleen
2005-05-24 9:31 ` [patch 0/4] " Shaohua Li
2005-05-25 22:16 ` Matthew Dobson
2005-05-26 0:11 ` Ashok Raj
-- strict thread matches above, loose matches on Subject: below --
2005-05-24 7:27 Ashok Raj
2005-05-24 7:27 ` [patch 1/4] " Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524085112.A20866@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustycorp.com.au \
--cc=shaohua.li@intel.com \
--cc=vatsa@in.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome