From: "Marty Leisner" <leisner@rochester.rr.com>
To: linux-kernel@vger.kernel.org
Subject: CONFIG_HOTPLUG, 2.4.x and ppc
Date: Tue, 24 May 2005 22:41:18 -0400 [thread overview]
Message-ID: <200505250241.j4P2fJtP024511@dell.home> (raw)
I'm dealing with a custom BRIDGE_OTHER chip, which has PCI devices
on the other side...the configuration cycles don't follow a standard, and
I'm trying to establish the bus behind the bridge when I install a module...
essentially I'm doing things similar to hotplug drivers...
I have no experience with hotplug drivers, but it appears to be incompatible
with the ppc architure...
Calling pci_do_scan_bus, it calls pcibios_fixup_bus.
In the 2.4 ppc kernels, pcibios_fixup_bus is defined to be:
void __init pcibios_fixup_bus(struct pci_bus *bus)
On intel, its defined to be:
void __devinit pcibios_fixup_bus(struct pci_bus *bus)
Since pci_do_scan_bus needs CONFIG_HOTPLUG, this path is exercised,
and pcibios_fixup_bus isn't present on ppc after bootup...
This patch is necessary if we CONFIG_HOTPLUG on ppc...there seems
to be no reason why not -- others changes like this might be necessary...
:1 mleisner@santa 04:28:16; rcsdiff -r1.1 -u arch/ppc/kernel/pci.c
===================================================================
RCS file: arch/ppc/kernel/pci.c,v
retrieving revision 1.1
diff -u -r1.1 arch/ppc/kernel/pci.c
--- arch/ppc/kernel/pci.c 2005/05/18 19:08:09 1.1
+++ arch/ppc/kernel/pci.c 2005/05/24 19:23:33
@@ -1384,7 +1384,7 @@
return start;
}
-void __init pcibios_fixup_bus(struct pci_bus *bus)
+void __devinit pcibios_fixup_bus(struct pci_bus *bus)
{
struct pci_controller *hose = (struct pci_controller *) bus->sysdata;
unsigned long io_offset;
The patch is wrt to 2.4.20, but 2.4.30 appears to have the same problem...
Marty Leisner
leisner@rochester.rr.com
next reply other threads:[~2005-05-25 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 2:41 Marty Leisner [this message]
2005-05-25 4:26 ` Greg KH
2005-05-25 5:23 ` Marty Leisner
2005-05-26 22:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505250241.j4P2fJtP024511@dell.home \
--to=leisner@rochester.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®