From: Chuck Ebbert <76306.1226@compuserve.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Chris Wright <chrisw@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-stable <stable@kernel.org>,
Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Chuck Wolber <chuckw@quantumlinux.com>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Daniel Drake <dsd@gentoo.org>
Subject: Re: [patch 07/16] ide-disk: Fix LBA8 DMA
Date: Wed, 25 May 2005 05:12:27 -0400 [thread overview]
Message-ID: <200505250514_MC3-1-9FB4-C35C@compuserve.com> (raw)
On Wed, 25 May 2005 at 03:57:14 -0400, Chuck Ebbert wrote:
> On Mon, 23 May 2005 at 16:24:14 -0700, Chris Wright wrote:
>
> > --- linux-2.6.11.10.orig/drivers/ide/ide-disk.c 2005-05-16 10:50:31.000000000 -0700
> > +++ linux-2.6.11.10/drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700
> > @@ -133,6 +133,8 @@
> > if (hwif->no_lba48_dma && lba48 && dma) {
> > if (block + rq->nr_sectors > 1ULL << 28)
>
> ^
>
> Maybe I'm an idiot, but shouldn't that be ">="? Either that or it should be
> comparing to (1ULL < 28 - 1)?
Oops, I forgot this was in my outbox and sent it before review. This code
is fine... (block + rq->nr_sectors) is one past the actual end of the read.
> > dma = 0;
> > + else
> > + lba48 = 0;
>
> ^^^^^^^^^^^^^^^^^^^^^^^
>
> Spaces instead of tabs?
But the patch really does seem to be tabdamaged...
--
Chuck
next reply other threads:[~2005-05-25 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 9:12 Chuck Ebbert [this message]
2005-05-25 13:29 ` Chris Wright
-- strict thread matches above, loose matches on Subject: below --
2005-05-25 7:57 Chuck Ebbert
2005-05-23 23:15 [00/16] -stable review Chris Wright
2005-05-23 23:24 ` [patch 07/16] ide-disk: Fix LBA8 DMA Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505250514_MC3-1-9FB4-C35C@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=chrisw@osdl.org \
--cc=chuckw@quantumlinux.com \
--cc=dsd@gentoo.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®