From: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
To: Ian Campbell <icampbell@arcom.com>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [UINPUT] Allow EV_ABS to work in uinput.c
Date: Wed, 25 May 2005 09:36:26 -0300 [thread overview]
Message-ID: <20050525123626.GC3772@cathedrallabs.org> (raw)
In-Reply-To: <1117023999.20237.8.camel@icampbell-debian>
> uinput_alloc_device() is supposed to return the number of bytes read,
> the value is returned to uinput_write() and from there to userspace. If
> EV_ABS is set then it returns the value from uinput_validate_absbits()
> instead, which is zero when everything is ok instead of the count.
>
> Signed-off-by: Ian Campbell <icampbell@arcom.com>
Acked-by: Aristeu Rozanski <aris@cathedrallabs.org>
> --- 2.6.orig/drivers/input/misc/uinput.c 2005-05-25 10:45:56.000000000 +0100
> +++ 2.6/drivers/input/misc/uinput.c 2005-05-25 10:47:02.000000000 +0100
> @@ -216,9 +216,11 @@
> /* check if absmin/absmax/absfuzz/absflat are filled as
> * told in Documentation/input/input-programming.txt */
> if (test_bit(EV_ABS, dev->evbit)) {
> - retval = uinput_validate_absbits(dev);
> - if (retval < 0)
> + int err = uinput_validate_absbits(dev);
> + if (err < 0) {
> + retval = err;
> kfree(dev->name);
> + }
> }
>
> exit:
--
Aristeu
next prev parent reply other threads:[~2005-05-25 12:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 12:26 Ian Campbell
2005-05-25 12:36 ` Aristeu Sergio Rozanski Filho [this message]
2005-05-31 14:31 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050525123626.GC3772@cathedrallabs.org \
--to=aris@cathedrallabs.org \
--cc=icampbell@arcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®