From: Vivek Goyal <vgoyal@in.ibm.com>
To: Alexander Nyberg <alexn@telia.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: Re: [Fastboot] [1/2] kdump: Use real pt_regs from exception
Date: Wed, 25 May 2005 18:36:07 +0530 [thread overview]
Message-ID: <20050525130607.GB3658@in.ibm.com> (raw)
In-Reply-To: <1117023296.877.11.camel@localhost.localdomain>
On Wed, May 25, 2005 at 02:14:56PM +0200, Alexander Nyberg wrote:
> ons 2005-05-25 klockan 02:07 -0700 skrev Andrew Morton:
> > Alexander Nyberg <alexn@telia.com> wrote:
> > >
> > > -extern void machine_crash_shutdown(void);
> > > +extern void machine_crash_shutdown(struct pt_regs *);
> >
> > That'll break x86_64, ppc, ppc64 and s/390.
>
> I'm such an idiot.
>
> Make sure all arches take pt_regs * as argument to
> machine_crash_shutdown(). (now cross-compiled on above arches except
> s/390).
>
Alexander, I face following warning if I build my kernel without HIGHMEM
support. Fianally linker fails in the end.
CC kernel/kexec.o
kernel/kexec.c: In function `kexec_should_crash':
kernel/kexec.c:37: warning: implicit declaration of function `in_interrupt'
If I include HIGHMEM support, it compiles fine.
You might have to include include/linux/hardirq.h in kexec.c to
resolve the problem.
Thanks
Vivek
next prev parent reply other threads:[~2005-05-25 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116103798.6153.30.camel@localhost.localdomain>
2005-05-18 12:35 ` Vivek Goyal
2005-05-18 14:51 ` Alexander Nyberg
2005-05-25 9:07 ` Andrew Morton
2005-05-25 12:14 ` Alexander Nyberg
2005-05-25 13:06 ` Vivek Goyal [this message]
2005-05-25 13:14 ` Alexander Nyberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050525130607.GB3658@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=akpm@osdl.org \
--cc=alexn@telia.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®