From: Jens Axboe <axboe@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: Resend: PATCH: Stop 2.6.12rc rmmod from being able to destroy CD hardware
Date: Fri, 27 May 2005 16:58:50 +0200 [thread overview]
Message-ID: <20050527145849.GY1435@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0505270751420.17402@ppc970.osdl.org>
On Fri, May 27 2005, Linus Torvalds wrote:
>
>
> On Fri, 27 May 2005, Alan Cox wrote:
> >
> > The simple fix is attached, making the driver start from ~0 and mask
> > bits the other direction would longer term be safer.
>
> As per Bartlomiej, I've not applied this, since the "don't do it unless
> you've written to it" fix from Jens went in. I assume CD-RW's know how to
> cache flush..
>
> That said, it does sound like the capabilities bitmap should be changed
> around to be the other way (either by starting at ~0, or, if the changes
> aren't too invasive, just change the semantics of it to be the sane way
> around ("drive can do this" rather than "drive can _not_ do this").
They should, it's always annoyed me because it's counter intuitive.
--
Jens Axboe
prev parent reply other threads:[~2005-05-27 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 12:18 Alan Cox
2005-05-27 14:27 ` Bartlomiej Zolnierkiewicz
2005-05-27 14:54 ` Linus Torvalds
2005-05-27 14:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050527145849.GY1435@suse.de \
--to=axboe@suse.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®