From: "David S. Miller" <davem@davemloft.net>
To: phdm@macqel.be
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH : ppp + big-endian = kernel crash
Date: Sun, 29 May 2005 13:52:57 -0700 (PDT) [thread overview]
Message-ID: <20050529.135257.98862077.davem@davemloft.net> (raw)
In-Reply-To: <200505291948.j4TJmgZ25169@mail.macqel.be>
From: "Philippe De Muyter" <phdm@macqel.be>
Date: Sun, 29 May 2005 21:48:42 +0200 (CEST)
> + /* If the address of the packet is odd now, fix it. */
> + if ((unsigned long)skb->data & 1) {
> + unsigned char *p;
And now it will crash when a packet is only 2-byte aligned
when the input packet processing does the first access
to the IP address in the packet header.
Please make your m68k port handle unaligned memory accesses
in kernel mode properly instead.
next prev parent reply other threads:[~2005-05-29 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-29 19:48 Philippe De Muyter
2005-05-29 20:52 ` David S. Miller [this message]
2005-05-29 21:38 ` Philippe De Muyter
2005-05-29 21:55 ` David S. Miller
2005-05-30 2:52 ` Andrew Morton
2005-05-30 3:11 ` David S. Miller
2005-06-01 15:26 ` Philippe De Muyter
2005-05-30 10:22 ` Andi Kleen
2005-05-30 13:01 ` cutaway
2005-05-30 7:16 ` Giuliano Pochini
2005-05-30 14:05 Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050529.135257.98862077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®