From: Tejun Heo <htejun@gmail.com>
To: axboe@suse.de, James.Bottomley@steeleye.com, bzolnier@gmail.com,
jgarzik@pobox.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH Linux 2.6.12-rc5-mm1 03/06] blk: make ide use -EOPNOTSUPP instead of -EIO on ABRT_ERR
Date: Sun, 29 May 2005 13:23:33 +0900 (KST) [thread overview]
Message-ID: <20050529042034.F9DC1D16@htj.dyndns.org> (raw)
In-Reply-To: <20050529042034.5FF4CF1C@htj.dyndns.org>
03_blk_ide_eopnotsupp.patch
Use -EOPNOTSUPP instead of -EIO on ABRT_ERR.
Signed-off-by: Tejun Heo <htejun@gmail.com>
ide-io.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletion(-)
Index: blk-fixes/drivers/ide/ide-io.c
===================================================================
--- blk-fixes.orig/drivers/ide/ide-io.c 2005-05-29 13:20:30.000000000 +0900
+++ blk-fixes/drivers/ide/ide-io.c 2005-05-29 13:20:31.000000000 +0900
@@ -305,6 +305,7 @@ void ide_end_drive_cmd (ide_drive_t *dri
ide_hwif_t *hwif = HWIF(drive);
unsigned long flags;
struct request *rq;
+ int uptodate;
spin_lock_irqsave(&ide_lock, flags);
rq = HWGROUP(drive)->rq;
@@ -379,7 +380,10 @@ void ide_end_drive_cmd (ide_drive_t *dri
blkdev_dequeue_request(rq);
HWGROUP(drive)->rq = NULL;
rq->errors = err;
- end_that_request_last(rq, !rq->errors);
+ uptodate = 1;
+ if (err)
+ uptodate = err & ABRT_ERR ? -EOPNOTSUPP : -EIO;
+ end_that_request_last(rq, uptodate);
spin_unlock_irqrestore(&ide_lock, flags);
}
next prev parent reply other threads:[~2005-05-29 4:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-29 4:23 [PATCH Linux 2.6.12-rc5-mm1 00/06] blk: barrier flushing reimplementation Tejun Heo
2005-05-29 4:23 ` [PATCH Linux 2.6.12-rc5-mm1 01/06] blk: add @uptodate to end_that_request_last() and @error to rq_end_io_fn() Tejun Heo
2005-05-29 4:23 ` [PATCH Linux 2.6.12-rc5-mm1 02/06] blk: make scsi use -EOPNOTSUPP instead of -EIO on ILLEGAL_REQUEST Tejun Heo
2005-05-29 4:23 ` Tejun Heo [this message]
2005-05-29 4:23 ` [PATCH Linux 2.6.12-rc5-mm1 04/06] blk: reimplement QUEUE_OREDERED_FLUSH Tejun Heo
2005-05-29 9:54 ` Tejun Heo
2005-05-29 4:23 ` [PATCH Linux 2.6.12-rc5-mm1 05/06] blk: turn on QUEUE_ORDERED_FLUSH by default if ordered tag isn't supported Tejun Heo
2005-05-29 4:23 ` [PATCH Linux 2.6.12-rc5-mm1 06/06] blk: debug messages Tejun Heo
2005-05-29 17:37 ` [PATCH Linux 2.6.12-rc5-mm1 00/06] blk: barrier flushing reimplementation Jeff Garzik
2005-05-29 19:14 ` Jens Axboe
2005-05-30 11:31 ` Jens Axboe
2005-05-30 19:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050529042034.F9DC1D16@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®