mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-pcmcia@lists.infradead.org, sakugawa@linux-m32r.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc5] m32r: Update m32r_cfc.[ch] to support Mappi-III platform
Date: Tue, 31 May 2005 15:19:23 +0100	[thread overview]
Message-ID: <20050531141923.GA28958@infradead.org> (raw)
In-Reply-To: <20050531.221702.1044949015.takata.hirokazu@renesas.com>

On Tue, May 31, 2005 at 10:17:02PM +0900, Hirokazu Takata wrote:
> Hello,
> 
> This patch is for the M32R CF/PCMCIA drivers to support a new platform,
> Mappi-III evaluation board.

Any chance you could cleanup the ifdef mess a little? e.g. adding a new
file for each platform and proper abstractions in the main source file.


  reply	other threads:[~2005-05-31 14:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31 13:17 Hirokazu Takata
2005-05-31 14:19 ` Christoph Hellwig [this message]
2005-05-31 14:45 ` Dominik Brodowski
2005-06-01 11:57   ` Hirokazu Takata
2005-06-02 10:11     ` [PATCH 2.6.12-rc5-mm2] m32r: m32r_cfc.c build fix Hirokazu Takata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050531141923.GA28958@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=sakugawa@linux-m32r.org \
    --cc=takata@linux-m32r.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®