From: Christoph Hellwig <hch@infradead.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Introduce tty_unregister_ldisc()
Date: Wed, 1 Jun 2005 06:42:51 +0100 [thread overview]
Message-ID: <20050601054251.GA12275@infradead.org> (raw)
In-Reply-To: <1117578491.4627.14.camel@at2.pipehead.org>
On Tue, May 31, 2005 at 05:28:11PM -0500, Paul Fulghum wrote:
> This patch is wrong. Please do not apply.
>
> An unmodified ldisc driver (externally maintained) will continue to call
> tty_register_ldisc with NULL, but the new behavior will be to set the
> ldisc pointer to NULL but have LDISC_FLAG_DEFINED set.
>
> If you feel it is absolutely necessary to add this new function
> for cosmetic reasons, then leave the old behavior in place
> and make tty_unregister_ldisc a wrapper to tty_register_ldisc
> that uses a NULL pointer.
Nah, we don't want to allow staying out of tree folks out of sync. Adding
a BUG_ON for ldisk beeing NULL is much more reasoable.
next prev parent reply other threads:[~2005-06-01 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 19:56 Alexey Dobriyan
2005-05-31 22:28 ` Paul Fulghum
2005-06-01 3:38 ` Paul Fulghum
2005-06-01 13:51 ` Paul Fulghum
2005-06-01 4:39 ` Greg KH
2005-06-01 5:42 ` Christoph Hellwig [this message]
2005-06-01 15:22 ` Alexey Dobriyan
2005-06-15 21:40 Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601054251.GA12275@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®