From: Stephen Hemminger <shemminger@osdl.org>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][1/3] RapidIO support: core
Date: Wed, 1 Jun 2005 13:37:57 -0700 [thread overview]
Message-ID: <20050601133757.624059c4@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <20050601110836.A16559@cox.net>
Quick review comments:
1. Why hack up vmlinux.lds.h? wouldn't declaring rio_route_ops
to be a constant do what you want?
2. Unnecessary initializers
+struct bus_type rio_bus_type = {
+ .name = "rapidio",
+ .match = rio_match_bus,
+ .suspend = NULL,
+ .resume = NULL,
NULL is unnecessary here.
3. Use existing macro's
+#define DEBUG
+
+#ifdef DEBUG
+#define DBG(x...) printk(x)
+#else
+#define DBG(x...)
+#endif
+
Use pr_debug() and isn't this debugged yet?
4. Lists should be static if possible
+
+LIST_HEAD(rio_mports);
static LIST_HEAD(rio_mports)
5. rio_nets defined but not used (if it is used later then
make it visible to only that code.)
6. rio_net_lock does it need to be global.
also maybe a name change to rio_global_list_lock
next prev parent reply other threads:[~2005-06-01 20:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 18:08 Matt Porter
2005-06-01 18:15 ` [PATCH][2/3] RapidIO support: ppc32 Matt Porter
2005-06-01 18:25 ` [PATCH][3/3] RapidIO support: net driver over messaging Matt Porter
2005-06-01 20:37 ` Stephen Hemminger [this message]
2005-06-01 22:05 ` [PATCH][1/3] RapidIO support: core Matt Porter
2005-06-01 22:58 ` Matt Porter
2005-06-02 0:00 ` Greg KH
2005-06-02 20:58 ` Matt Porter
2005-06-02 0:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601133757.624059c4@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®