From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: XIAO Gang <xiao@unice.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Suggestion on "int len" sanity
Date: Thu, 2 Jun 2005 11:47:14 +0200 [thread overview]
Message-ID: <20050602094714.GA3218@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <429ECD6D.8000503@unice.fr>
On Thu, 2 June 2005 11:12:13 +0200, XIAO Gang wrote:
> >
> I know; I might try to do something later. The question here is to find
> the best balancing point between what
> are better replaced and what are not. I would hesitate a lot before
> doing things as below which are more likely to introduce new bugs than
> to avoid old ones.
In some cases a comment like "this sucks, but we have to do it
because.." helps. Example 2 can also be changed to size_t, that one
makes sense.
"grep 'int len'" really is a decent code checker, I agree. The hard
part is finding the 2% real problems among the output. And possibly
other cases where s/int/size_t/ doesn't fix anything, but makes
slightly more sense.
Jörn
--
Man darf nicht das, was uns unwahrscheinlich und unnatürlich erscheint,
mit dem verwechseln, was absolut unmöglich ist.
-- Carl Friedrich Gauß
next prev parent reply other threads:[~2005-06-02 9:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 7:28 XIAO Gang
2005-06-02 8:48 ` Jörn Engel
2005-06-02 9:12 ` XIAO Gang
2005-06-02 9:47 ` Jörn Engel [this message]
2005-06-03 9:45 ` Geert Uytterhoeven
2005-06-03 12:20 ` Al Viro
2005-06-03 14:19 ` Jörn Engel
2005-06-03 12:28 ` Andreas Schwab
2005-06-03 12:43 ` Geert Uytterhoeven
2005-06-03 14:38 ` Andreas Schwab
2005-06-03 18:04 ` randy_dunlap
2005-06-03 18:09 ` Lars Marowsky-Bree
2005-06-03 18:16 ` randy_dunlap
2005-06-04 11:28 ` Christoph Hellwig
2005-06-04 16:58 ` randy_dunlap
2005-06-04 17:07 ` Jörn Engel
2005-06-04 17:11 ` randy_dunlap
-- strict thread matches above, loose matches on Subject: below --
2005-06-01 7:06 XIAO Gang
2005-06-01 13:46 ` Jörn Engel
2005-06-01 20:39 ` Willy Tarreau
2005-06-03 9:42 ` Geert Uytterhoeven
2005-06-03 12:47 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050602094714.GA3218@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xiao@unice.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®