From: Andrew Morton <akpm@osdl.org>
To: Matt Porter <mporter@kernel.crashing.org>
Cc: kumar.gala@freescale.com, linux-kernel@vger.kernel.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] cpm_uart: Route SCC2 pins for the STx GP3 board
Date: Thu, 2 Jun 2005 15:35:40 -0700 [thread overview]
Message-ID: <20050602153540.53486bde.akpm@osdl.org> (raw)
In-Reply-To: <20050601105145.B15351@cox.net>
Matt Porter <mporter@kernel.crashing.org> wrote:
>
> +++ uncommitted/drivers/serial/cpm_uart/cpm_uart_cpm2.c (mode:100644)
> @@ -134,12 +134,21 @@
>
> void scc2_lineif(struct uart_cpm_port *pinfo)
> {
> + /*
> + * STx GP3 uses the SCC2 secondary option pin assignment
> + * which this driver doesn't account for in the static
> + * pin assignments. This kind of board specific info
> + * really has to get out of the driver so boards can
> + * be supported in a sane fashion.
> + */
> +#ifndef CONFIG_STX_GP3
> volatile iop_cpm2_t *io = &cpm2_immr->im_ioport;
> io->iop_pparb |= 0x008b0000;
Silly question: why is this driver using a volatile pointer to
memory-mapped I/O rather than readl and writel?
next prev parent reply other threads:[~2005-06-02 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 17:51 Matt Porter
2005-06-02 22:35 ` Andrew Morton [this message]
2005-06-03 3:29 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050602153540.53486bde.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome