mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Rosmanith <kernel@wildsau.enemy.org>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, Herbert Rosmanith <kernel@wildsau.enemy.org>
Subject: [PATCH] struct thread_struct, asm-i386/processor.h: wrong datatype?
Date: Sat, 4 Jun 2005 17:43:06 +0200 (MET DST)	[thread overview]
Message-ID: <200506041543.j54Fh7xv018234@wildsau.enemy.org> (raw)


good day,

concerning this file:

/usr/src/linux/include/asm-i386/processor.h

we find a "struct thread_struct":

struct thread_struct {
        unsigned long   esp0;
        unsigned long   eip;
        unsigned long   esp;
        unsigned long   fs;
        ^^^^^^^^^^^^^^^^^^^
        unsigned long   gs;
        ^^^^^^^^^^^^^^^^^^^

as segment-registers, aren't fs and gs only 16 bit? why are they not
unsigned short (or possibly u_int16_t)?

kind regards,
herbert rosmanith

# diff -uN processor.h.orig processor.h
--- processor.h.orig    Wed Feb 18 14:36:32 2004
+++ processor.h Sat Jun  4 17:41:58 2005
@@ -2,6 +2,9 @@
  * include/asm-i386/processor.h
  *
  * Copyright (C) 1994 Linus Torvalds
+ *
+ * Sat Jun  4 17:41:23 MET DST 2005 herp - Herbert Rosmanith
+ *  fix wrong datatypes in struct thread_struct
  */

 #ifndef __ASM_I386_PROCESSOR_H
@@ -361,8 +364,8 @@
        unsigned long   esp0;
        unsigned long   eip;
        unsigned long   esp;
-       unsigned long   fs;
-       unsigned long   gs;
+       unsigned short  fs;
+       unsigned short  gs;
 /* Hardware debugging registers */
        unsigned long   debugreg[8];  /* %%db0-7 debug registers */
 /* fault info */


             reply	other threads:[~2005-06-04 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-04 15:43 Herbert Rosmanith [this message]
2005-06-04 16:01 ` Herbert Rosmanith
2005-06-06  8:16   ` Ingo Molnar
2005-06-08 21:08     ` Herbert Rosmanith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506041543.j54Fh7xv018234@wildsau.enemy.org \
    --to=kernel@wildsau.enemy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®