From: Andrew Morton <akpm@osdl.org>
To: Ashok Raj <ashok.raj@intel.com>
Cc: linux-kernel@vger.kernel.org, zwane@arm.linux.org.uk,
vatsa@in.ibm.com, discuss@x86-64.org, rusty@rustycorp.com.au,
ashok.raj@intel.com, ak@muc.de
Subject: Re: [patch 4/5] try2: x86_64: Dont use broadcast shortcut to make it cpu hotplug safe.
Date: Mon, 6 Jun 2005 15:13:32 -0700 [thread overview]
Message-ID: <20050606151332.3e457433.akpm@osdl.org> (raw)
In-Reply-To: <20050606192113.307745000@araj-em64t>
Ashok Raj <ashok.raj@intel.com> wrote:
>
> +static void flat_send_IPI_allbutself(int vector)
> +{
> + cpumask_t mask;
> + /*
> + * if there are no other CPUs in the system then
> + * we get an APIC send error if we try to broadcast.
> + * thus we have to avoid sending IPIs in this case.
> + */
> + get_cpu();
> + mask = cpu_online_map;
> + cpu_clear(smp_processor_id(), mask);
> +
> + if (cpus_weight(mask) >= 1)
> + flat_send_IPI_mask(mask, vector);
> +
> + put_cpu();
> +}
It would be more idiomatic to use preempt_disable() and preempt_enable() in
place of get_cpu() and put_cpu() here.
next prev parent reply other threads:[~2005-06-06 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 19:14 [patch 0/5] x86_64: try2: CPU hotplug patch series Ashok Raj
2005-06-06 19:14 ` [patch 1/5] try2: x86_64: Change init sections for CPU hotplug support Ashok Raj
2005-06-06 19:14 ` [patch 2/5] try2: x86_64: " Ashok Raj
2005-06-06 22:11 ` Andrew Morton
2005-06-06 22:43 ` Ashok Raj
2005-06-06 19:14 ` [patch 3/5] try2: x86_64: CPU hotplug sibling map cleanup Ashok Raj
2005-06-06 19:14 ` [patch 4/5] try2: x86_64: Dont use broadcast shortcut to make it cpu hotplug safe Ashok Raj
2005-06-06 22:13 ` Andrew Morton [this message]
2005-06-07 7:13 ` Shaohua Li
2005-06-07 12:05 ` Ashok Raj
2005-06-07 15:40 ` Ashok Raj
2005-06-06 19:14 ` [patch 5/5] try2: x86_64: Provide ability to choose using shortcuts for IPI in flat mode Ashok Raj
2005-06-06 22:14 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606151332.3e457433.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@muc.de \
--cc=ashok.raj@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustycorp.com.au \
--cc=vatsa@in.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®