Re: [PATCH] shmem: restore superblock info

[Brent Casavant <bcasavan@sgi.com>]

On Mon, 6 Jun 2005, Hugh Dickins wrote:

> On Mon, 6 Jun 2005, Brent Casavant wrote:
> > On Mon, 6 Jun 2005, Hugh Dickins wrote:
> > 
> > > @@ -1607,15 +1582,17 @@ static int shmem_statfs(struct super_blo
> > > -	if (sbinfo) {
> > > -		spin_lock(&sbinfo->stat_lock);
> > > +	spin_lock(&sbinfo->stat_lock);
> ...
> > 
> > This is the only change I'm at all concerned about.
> 
> Thanks for noticing, I hadn't really considered that.
> 
> > I'm not sure how frequent statfs operations occur in practice (I suspect
> > infrequently),
> 
> Infrequently, yes.  I think infrequently to the point of never in
> the case that concerns you: correct if I'm wrong, someone, but I think
> there's actually no handle by which user can statfs shm's internal mount.

Ah, that's an even better point, which I had failed to consider.  Consider
my concerns duly nullified. :)

Thanks for CC'ing me on the change.

Brent

-- 
Brent Casavant                          If you had nothing to fear,
bcasavan@sgi.com                        how then could you be brave?
Silicon Graphics, Inc.                    -- Queen Dama, Source Wars