From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261760AbVFFWj5 (ORCPT ); Mon, 6 Jun 2005 18:39:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261752AbVFFWhB (ORCPT ); Mon, 6 Jun 2005 18:37:01 -0400 Received: from fire.osdl.org ([65.172.181.4]:57244 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S261739AbVFFWfP (ORCPT ); Mon, 6 Jun 2005 18:35:15 -0400 Date: Mon, 6 Jun 2005 15:35:55 -0700 From: Andrew Morton To: jdike@addtoit.com, torvalds@osdl.org, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH 5/5] UML - clean up error path Message-Id: <20050606153555.3eb4cb2f.akpm@osdl.org> In-Reply-To: <20050606153118.1f7a413f.akpm@osdl.org> References: <200506062008.j56K8BKG008967@ccure.user-mode-linux.org> <20050606153118.1f7a413f.akpm@osdl.org> X-Mailer: Sylpheed version 1.0.0 (GTK+ 1.2.10; i386-vine-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > > Jeff Dike wrote: > > > > This cleans an error path which used to leak file descriptors by returning > > without trying to tidy up. > > The code in 2.6.12-rc6 is quite different from whatever you've patched here. Ah. Please ignore. The patches arrived out-of-order, with a huge time gap.