From: Andi Kleen <ak@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mbind: check_range use standard ptwalk
Date: Tue, 7 Jun 2005 16:39:33 +0200 [thread overview]
Message-ID: <20050607143933.GG23831@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0506062048430.5000@goblin.wat.veritas.com>
On Mon, Jun 06, 2005 at 08:49:38PM +0100, Hugh Dickins wrote:
> Strict mbind's check for currently mapped pages being on node has been
> using a slow loop which re-evaluates pgd, pud, pmd, pte for each entry:
> replace that by a standard four-level page table walk like others in mm.
> Since mmap_sem is held for writing, page_table_lock can be taken at the
> inner level to limit latency.
I doubt you will be able to benchmark a difference since the inner loop
should be normally memory bound anyways, giving the CPU plenty
of time to do some cache accesses. But ok.
-Andi
next prev parent reply other threads:[~2005-06-07 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 19:48 [PATCH 1/2] mbind: fix verify_pages pte_page Hugh Dickins
2005-06-06 19:49 ` [PATCH 2/2] mbind: check_range use standard ptwalk Hugh Dickins
2005-06-07 14:39 ` Andi Kleen [this message]
2005-06-07 14:38 ` [PATCH 1/2] mbind: fix verify_pages pte_page Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050607143933.GG23831@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®