mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	nsankar@broadcom.com
Subject: Re: [PATCH] PCI: MSI functionality broken on Serverworks GC chipset
Date: Thu, 09 Jun 2005 15:31:03 -0700 (PDT)	[thread overview]
Message-ID: <20050609.153103.39157619.davem@davemloft.net> (raw)
In-Reply-To: <20050609222133.GB12580@kroah.com>

From: Greg KH <gregkh@suse.de>
Date: Thu, 9 Jun 2005 15:21:33 -0700

> [PATCH] PCI: MSI functionality broken on Serverworks GC chipset
> 
> MSI functionality is broken on the GC_LE x86 chipset that Serverworks
> developed and that is being used in various platforms today. Broadcom is
> going to push out to the kernel MSI enabled Gigabit drivers (in the very
> near future), and we would like to make sure that MSI does not get
> enabled on any platforms using the GC_LE chipset (device id 0x17).
> Following the AMD 8131 example, I am including a patch to disable MSI
> functionality when a GCNB_LE is detected. Please let me know if there
> are any issues with this. This is a permanent fix for this chipset, as
> the hardware will not be updated.
> 
> Signed-off-by: Narendra Sankar <nsankar@broadcom.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

"Broadcom's driver" already has MSI support and has a self-test that
checks if MSI operates correctly, and will back out of using MSI if
the MSI test does not pass.

So this patch is not needed for proper functioning of that driver.

This changelog description is very misleading, at best.

  reply	other threads:[~2005-06-09 22:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-09 22:20 [GIT PATCH] Another PCI fix for 2.6.12-rc6 Greg KH
2005-06-09 22:21 ` [PATCH] PCI: MSI functionality broken on Serverworks GC chipset Greg KH
2005-06-09 22:31   ` David S. Miller [this message]
2005-06-09 22:32 ` [GIT PATCH] Another PCI fix for 2.6.12-rc6 David S. Miller
2005-06-09 22:48   ` Narendra Sankar
2005-06-09 22:51     ` David S. Miller
2005-06-09 22:56       ` Narendra Sankar
2005-06-09 22:55     ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050609.153103.39157619.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=nsankar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome