From: Kay Sievers <kay.sievers@vrfy.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Patch series to remove devfs [00/22]
Date: Sat, 11 Jun 2005 17:44:21 +0200 [thread overview]
Message-ID: <20050611154421.GA20373@vrfy.org> (raw)
In-Reply-To: <20050611153656.GB3770@stusta.de>
On Sat, Jun 11, 2005 at 05:36:56PM +0200, Adrian Bunk wrote:
> On Sat, Jun 11, 2005 at 07:39:04AM -0700, Greg KH wrote:
> > On Sat, Jun 11, 2005 at 12:21:34PM +0200, Adrian Bunk wrote:
> > > On Sat, Jun 11, 2005 at 12:43:27AM -0700, Greg KH wrote:
> > > >...
> > > > Comments welcome.
> > > >...
> > >
> > > Please don't remove the !CONFIG_DEVFS_FS dummies from devfs_fs_kernel.h.
> > >
> > > I'm sure some driver maintainers will want to keep the functions in
> > > their code because they share their drivers between 2.4 and 2.6 .
> >
> > All drivers should be in the mainline kernel tree, so why would they
> > need this? Remember, out-of-the-tree drivers are on their own...
>
> I'm talking about drivers in the mainline kernel tree.
>
> In some cases the driver author supports both 2.4 and 2.6 and prefers to
> support them in one file. Sometimes he submits the latest version of his
> driver to Marcelo or Linus.
>
> If you remove the global function dummies, you force every driver
> maintainer who works this way to add the function dummies to their
> drivers.
>
> Yes, there are many places where 2.4 and 2.6 are not source compatible
> for good reasons. But if the effort for maintaining compatibility
> between 2.4 and 2.6 in one area is as easy as keeping a header file with
> some dummy funtions it's worth considering.
>
> And keeping the compatibility stuff in one file instead of spreaded
> through the kernel sources makes the cleanup to remove the last
> occurences a few years from now easier.
How do these 2.4+2.6 drivers integrate with sysfs? Without proper
2.6-driver-core integration they will not work anyway.
Kay
next prev parent reply other threads:[~2005-06-11 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 7:43 Greg KH
2005-06-11 10:21 ` Adrian Bunk
2005-06-11 14:39 ` Greg KH
2005-06-11 15:36 ` Adrian Bunk
2005-06-11 15:41 ` Christoph Hellwig
2005-06-11 15:59 ` Adrian Bunk
2005-06-11 15:44 ` Kay Sievers [this message]
2005-06-11 20:14 ` [2.6 patch] fix compile errors and warning after devfs removal patches Adrian Bunk
2005-06-16 21:34 ` Greg KH
2005-06-12 22:44 ` [RFC] Patch series to remove devfs [00/22] J.A. Magallon
2005-06-13 17:43 ` Greg KH
2005-06-13 19:51 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050611154421.GA20373@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®