mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Timothy R. Chavez" <tinytim@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, Serge Hallyn <serue@us.ibm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Steve Grubb <sgrubb@redhat.com>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	Chris Wright <chrisw@osdl.org>,
	Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	Mounir Bsaibes <bsaibes@us.ibm.com>
Subject: Re: [RFC][PATCH] filesystem auditing by location+name
Date: Sat, 11 Jun 2005 18:00:22 +0100	[thread overview]
Message-ID: <20050611170021.GA1175@infradead.org> (raw)
In-Reply-To: <200506111155.12439.tinytim@us.ibm.com>

On Sat, Jun 11, 2005 at 11:55:11AM -0500, Timothy R. Chavez wrote:
> 1) Coverage
> 
> Inotify is only interested in a portion of the fs ops that we are interested 
> in.  Most notably, we need the ability to generate records every time the 
> [exec_]permission[_lite]() function is called.

That still means you could use the same infrastructure and now forward
these events to inotify-ish clients, right?

> 2) Processing
> 
> The processing of events has to occur in the kernel, not in user space.  
> Inotify collects events and tosses them back over the fence for processing.  
> We cannot introduce any window of opportunity for audit subversion.

still means it could be a client to the same core event processing code
and filesystem hooks, right?

> 
> You see, auditfs is interested in the inode at location+name, whatever it may 
> be when the auditable event occurs.  Thus, we've had to hook dcache to help 
> us with this processing.  This is something Inotify does not care about nor 
> should it.

Nor should the auditing code.  There's no way to find a good name for an
inode _at all_, and only the last pathname component for a dentry.  If you
try anything else your code is broken and will not get anywhere the mainline
kernel.

> 3) Queue
> 
> Depending on the work, there may be a requirement that no audit record can be 
> lost.  The message queue structure of inotify has the potential to overflow 
> and drop events.  This is a no-go for us, but perfectly reasonable for 
> inotify.
> 
> To make this work for us we'd have to hook the queueing functions to forward 
> events on to the audit subsystem.  This would basically mean fitting a system 
> that has been designed for interaction with userspace to also have 
> interaction with other parts of the kernel... again, hackish.

Or build inotify ontop of your system.  It's not like inotify is perfect
as-is (it's not, the userland interface is extremly horrible)


  reply	other threads:[~2005-06-11 17:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-10 22:28 Timothy R. Chavez
2005-06-10 22:38 ` Christoph Hellwig
2005-06-11 16:55   ` Timothy R. Chavez
2005-06-11 17:00     ` Christoph Hellwig [this message]
2005-06-11 17:40       ` Timothy R. Chavez
2005-06-10 23:28 ` Chris Wright
2005-06-13 20:45   ` Timothy R. Chavez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050611170021.GA1175@infradead.org \
    --to=hch@infradead.org \
    --cc=bsaibes@us.ibm.com \
    --cc=chrisw@osdl.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=serue@us.ibm.com \
    --cc=sgrubb@redhat.com \
    --cc=tinytim@us.ibm.com \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®