From: Willy Tarreau <willy@w.ods.org>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Assuming NULL
Date: Sat, 11 Jun 2005 19:24:19 +0200 [thread overview]
Message-ID: <20050611172419.GE28759@alpha.home.local> (raw)
In-Reply-To: <Pine.LNX.4.61.0506111823440.19223@yvahk01.tjqt.qr>
Hi Jan,
On Sat, Jun 11, 2005 at 06:24:22PM +0200, Jan Engelhardt wrote:
(...)
> My question is: Which one is right wrt the case "i_op ==/!= NULL"?
> There are two ways:
>
> - the kernel assumes i_op (and similar) is always non-NULL
> => then we can remove a lot of checks, like the first example above
>
> - the kernel does not assume...
> => then we need some extra checks, like in the second example above
and in any case, adding a comment telling why it CAN or why it CANNOT
be NULL would prevent other people from having to redo the same work
in 6 months.
Willy
next prev parent reply other threads:[~2005-06-11 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 16:24 Jan Engelhardt
2005-06-11 16:49 ` Måns Rullgård
2005-06-11 17:17 ` Jan Engelhardt
2005-06-11 17:24 ` Willy Tarreau [this message]
2005-06-11 17:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050611172419.GE28759@alpha.home.local \
--to=willy@w.ods.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®