From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261183AbVFLNKZ (ORCPT ); Sun, 12 Jun 2005 09:10:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261508AbVFLNKZ (ORCPT ); Sun, 12 Jun 2005 09:10:25 -0400 Received: from animx.eu.org ([216.98.75.249]:31682 "EHLO animx.eu.org") by vger.kernel.org with ESMTP id S261183AbVFLNKT (ORCPT ); Sun, 12 Jun 2005 09:10:19 -0400 Date: Sun, 12 Jun 2005 09:05:28 -0400 From: Wakko Warner To: Oliver Neukum Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: Problem found: kaweth fails to work on 2.6.12-rc[456] Message-ID: <20050612130527.GB9401@animx.eu.org> Mail-Followup-To: Oliver Neukum , linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20050612004136.GA8107@animx.eu.org> <200506120957.55214.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200506120957.55214.oliver@neukum.org> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Oliver Neukum wrote: > Am Sonntag, 12. Juni 2005 02:41 schrieb Wakko Warner: > > After doing some testing, I believe a patch that went into rc4 broke kaweth. > > The kaweth driver itself did not change from rc2 through rc6. > > > > As a test, I reverted a patch that went into rc4 which modified > > net/core/link_watch.c. Once I compiled the kernel, my netgear EA101 works > > again. > > > > The above is not cut'n'paste. There was 1 other addition (an include) that > > I removed from the patch inorder to revert it. The patch above was applied > > to 2.6.12-rc6 using -Rp1. This is why I believe that kaweth is broken. > > With my limited understanding of the kernel, it would appear that kaweth > > doesn't support netif_carrier_ok properly. > > Anyway, I found what caused it to break, but at this point, I do not have > > the required knowledge to do a proper fix. > > static void int_callback(struct urb *u, struct pt_regs *regs) > is supposed to handle the link state. Maybe it fails in your case. Could you > add a printk to this callback to check linkstate? I don't believe my case is very specific. I've tested this on 4 different systems with totally different configs. If it is at all specific, I believe it would be with the network adapter itself. I don't have any other usb adapters that use kaweth. Can you tell me where I need to add the printks? -- Lab tests show that use of micro$oft causes cancer in lab animals