From: Andrew Morton <akpm@osdl.org>
To: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Cc: yuasa@hh.iij4u.or.jp, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc6] add vr41xx gpio support
Date: Mon, 13 Jun 2005 15:19:40 -0700 [thread overview]
Message-ID: <20050613151940.24ac347d.akpm@osdl.org> (raw)
In-Reply-To: <20050612032827.31ac649a.yuasa@hh.iij4u.or.jp>
Yoichi Yuasa <yuasa@hh.iij4u.or.jp> wrote:
>
> This patch had added vr41xx gpio support.
> --- git5-orig/drivers/char/Kconfig Tue Jun 7 00:22:29 2005
> +++ git5/drivers/char/Kconfig Sun Jun 12 02:37:20 2005
> @@ -929,6 +929,10 @@
>
> If compiled as a module, it will be called scx200_gpio.
>
> +config GPIO_VR41XX
> + tristate "NEC VR4100 series General-purpose I/O Unit support"
> + depends CPU_VR41XX
> +
Does that even work? We normally use "depends on". I'll change it.
> +EXPORT_SYMBOL_GPL(vr41xx_set_irq_trigger);
> +EXPORT_SYMBOL_GPL(vr41xx_set_irq_level);
> +EXPORT_SYMBOL_GPL(vr41xx_gpio_get_pin);
> +EXPORT_SYMBOL_GPL(vr41xx_gpio_set_pin);
> +EXPORT_SYMBOL_GPL(vr41xx_gpio_set_direction);
> +EXPORT_SYMBOL_GPL(vr41xx_gpio_pullupdown);
Why are these symbols exported?
next prev parent reply other threads:[~2005-06-13 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 18:28 Yoichi Yuasa
2005-06-13 22:19 ` Andrew Morton [this message]
2005-06-14 13:02 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613151940.24ac347d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuasa@hh.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®