From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
video4linux-list@redhat.com
Subject: Re: [PATCH] Adds support for TEA5767 chipset on V4L
Date: Mon, 13 Jun 2005 18:35:23 +0200 [thread overview]
Message-ID: <20050613183523.322529e0.khali@linux-fr.org> (raw)
In-Reply-To: <42ACAA3B.8050307@brturbo.com.br>
Hi Mauro,
> PS 3: There were some I2C changes that affected V4L on 2.6.12-rc6-mm1.
> Now, it is necessary to use probe option in tuner to have its I2C
> addresses recognized by V4L. New patches will come to correct this
> behavior.
Which i2c patch please? The changes I made should not cause any trouble
to V4L drivers. If they do this is a bug, please report it as such.
Also, a comment on your patch (which I didn't actually review, as I do
not feel qualified to do so):
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> +#include "tuner.h"
> +#include "i2c-compat.h"
> +#else
> +#include <media/tuner.h>
> +#endif
No such test please, it is useless. This is Linux 2.6.x, no need to
check this.
--
Jean Delvare
next prev parent reply other threads:[~2005-06-13 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-12 21:33 Mauro Carvalho Chehab
2005-06-13 16:35 ` Jean Delvare [this message]
2005-06-13 18:41 ` Mauro Carvalho Chehab
2005-06-14 7:29 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613183523.322529e0.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®