mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Pascal CHAPPERON <pascal.chapperon@wanadoo.fr>
Cc: Andrew Hutchings <info@a-wing.co.uk>,
	linux-kernel@vger.kernel.org, vinay kumar <b4uvin@yahoo.co.in>,
	jgarzik@pobox.com
Subject: Re: sis190
Date: Mon, 13 Jun 2005 23:39:50 +0200	[thread overview]
Message-ID: <20050613213950.GA8081@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <18320560.1118650748703.JavaMail.www@wwinf1518>

Pascal CHAPPERON <pascal.chapperon@wanadoo.fr> :
[...]
> NOTE : here is something strange about base address =>
> dmesg :  sis190 at ffffc20000004c00 (IRQ: 11)
> ifconfig :          Interrupt:11 Base address:0xbeef

Don't bother: the base address in the struct netdevice is obsolete. I'll
turn it into 0xdead.

[tcpdump output]
> It seems that sis190 driver shifts 4 bytes...

Ok (it looks like a 2 bytes offset though).

> further test about autoneg, probably silly:
> be nice, as i know nothing to network drivers dev.
> i do not understand what is LPA_SLCT...

Ahem. It was not a great idea from me to convert from 31 to LPA_SLCT
as LPA_SLCT is intended to be a bitmask, not a register shift.

> # diff -puN sis190-20050611a.c sis190.c
> --- sis190-20050611a.c  2005-06-13 08:54:56.000000000 +0200
> +++ sis190.c    2005-06-13 09:41:29.000000000 +0200
[...]
> @@ -823,18 +823,17 @@ static void sis190_phy_task(void * data)
>                         u16 ctl;
>                         const char *msg;
>                 } reg31[] = {
> -                       { _1000bpsF,    0x1c01, "1000 bps Full Duplex" },
> -                       { _1000bpsH,    0x0c01, "1000 bps Half Duplex" },
> -                       { _100bpsF,     0x1801, "100 bps Full Duplex" },
> -                       { _100bpsH,     0x0801, "100 bps Half Duplex" },
> -                       { _10bpsF,      0x1401, "10 bps Full Duplex" },
> -                       { _10bpsH,      0x0401, "10 bps Half Duplex" },
> +                       { LPA_1000XFULL | LPA_SLCT,  0x1c01, "1000 bps Full Duplex" },
> +                       { LPA_1000XHALF | LPA_SLCT,  0x0c01, "1000 bps Half Duplex" },
> +                       { LPA_100FULL,  0x1801, "100 bps Full Duplex" },
> +                       { LPA_100HALF,  0x0901, "100 bps Half Duplex" },
> +                       { LPA_10FULL,   0x1401, "10 bps Full Duplex" },
> +                       { LPA_10HALF,   0x0401, "10 bps Half Duplex" },
>                         { 0,            0x0000, "unknown" }
>                 }, *p;
> -               val = mdio_read(ioaddr, LPA_SLCT) & 0x1c; // bit 4:2
> -
> +               val = mdio_read(ioaddr, MII_LPA);
>                 for (p = reg31; p->ctl; p++) {
> -                       if (val == p->val)
> +                 if ((val &  p->val) == p->val)
>                                 break;
>                 }
>                 if (p->ctl)
[and it works]

Cool. Ok, I take that and I'll sprinkle a few printks here and there.

Can you give a try at:
http://www.fr.zoreil.com/people/francois/misc/20050613-2.6.12-rc-sis190-test.patch

dmesg + ifconfig + tcpdump (please add a -e option) will be welcome as usual.

If the driver starts to behave in an usually better way, please issue
differently sized ping packets to cover the whole allowed range.

--
Ueimor

  reply	other threads:[~2005-06-13 21:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-13  8:19 sis190 Pascal CHAPPERON
2005-06-13 21:39 ` Francois Romieu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-07-10 13:23 sis190 Pascal CHAPPERON
2005-07-09 13:25 sis190 Pascal CHAPPERON
2005-07-09 20:57 ` sis190 Francois Romieu
2005-07-06 15:58 sis190 Pascal CHAPPERON
2005-07-06 21:29 ` sis190 Francois Romieu
2005-07-02 10:52 sis190 Pascal CHAPPERON
2005-07-02 11:33 ` sis190 Francois Romieu
2005-07-04 23:30 ` sis190 Francois Romieu
2005-06-26 12:39 sis190 Pascal CHAPPERON
2005-06-30 23:37 ` sis190 Francois Romieu
2005-06-19 10:17 sis190 Pascal CHAPPERON
2005-06-21 23:02 ` sis190 Francois Romieu
2005-06-17 11:14 sis190 Pascal CHAPPERON
2005-06-17 18:22 ` sis190 Francois Romieu
2005-06-15 15:22 sis190 Pascal CHAPPERON
2005-06-16 22:34 ` sis190 Francois Romieu
2005-06-14 14:14 sis190 Pascal CHAPPERON
2005-06-14 20:04 ` sis190 Francois Romieu
2005-06-11  9:39 sis190 Pascal CHAPPERON
2005-06-11 10:56 ` sis190 Francois Romieu
2005-06-07 22:37 sis5513.c patch Andrew Hutchings
2005-06-07 22:57 ` Francois Romieu
2005-06-07 23:20   ` Andrew Hutchings
2005-06-08 22:51     ` sis190 (was: Re: sis5513.c patch) Francois Romieu
2005-06-09  4:54       ` sis190 Andrew Hutchings
2005-06-09 12:02       ` sis190 Andrew Hutchings
2005-06-09 21:18         ` sis190 Francois Romieu
2005-06-10 13:55           ` sis190 Andrew Hutchings
2005-06-10 23:41             ` sis190 Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050613213950.GA8081@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=b4uvin@yahoo.co.in \
    --cc=info@a-wing.co.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pascal.chapperon@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®