From: Jakub Bogusz <qboosh@pld-linux.org>
To: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: [PATCH 2.4][SPARC64] fix sys32_utimes(somefile, NULL)
Date: Tue, 14 Jun 2005 21:23:06 +0200 [thread overview]
Message-ID: <20050614192306.GC13702@fngna.oyu> (raw)
This patch fixes utimes(somefile, NULL) syscalls on sparc64 kernel with
32-bit userland - use of uninitialized value resulted in making random
timestamps, which confused e.g. sudo.
It has been already fixed (by davem) in linux-2.6 tree 30 months ago.
Signed-off-by: Jakub Bogusz <qboosh@pld-linux.org>
--- linux-2.4.31/arch/sparc64/kernel/sys_sparc32.c.orig 2005-06-06 14:55:31.000000000 +0200
+++ linux-2.4.31/arch/sparc64/kernel/sys_sparc32.c 2005-06-14 12:00:15.000000000 +0200
@@ -4267,7 +4267,7 @@
old_fs = get_fs();
set_fs(KERNEL_DS);
- ret = sys_utimes(kfilename, &ktvs[0]);
+ ret = sys_utimes(kfilename, (tvs ? &ktvs[0] : NULL));
set_fs(old_fs);
putname(kfilename);
--
Jakub Bogusz http://qboosh.cs.net.pl/
next reply other threads:[~2005-06-14 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 19:23 Jakub Bogusz [this message]
2005-06-14 19:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050614192306.GC13702@fngna.oyu \
--to=qboosh@pld-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®