mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH Linux 2.6.12-rc6-mm1 05/06] blk: remove last_merge handling from noop iosched
Date: Thu, 16 Jun 2005 13:57:04 +0900 (KST)	[thread overview]
Message-ID: <20050616045540.947E3AD5@htj.dyndns.org> (raw)
In-Reply-To: <20050616045540.E3E4D48B@htj.dyndns.org>

05_blk_last_merge_consolidation_noop.patch

	Remove last_merge handling from noop iosched.  This change
	removes merging capability of noop iosched.

Signed-off-by: Tejun Heo <htejun@gmail.com>

 noop-iosched.c |   31 -------------------------------
 1 files changed, 31 deletions(-)

Index: blk-fixes/drivers/block/noop-iosched.c
===================================================================
--- blk-fixes.orig/drivers/block/noop-iosched.c	2005-06-16 13:55:38.000000000 +0900
+++ blk-fixes/drivers/block/noop-iosched.c	2005-06-16 13:55:38.000000000 +0900
@@ -7,38 +7,9 @@
 #include <linux/module.h>
 #include <linux/init.h>
 
-/*
- * See if we can find a request that this buffer can be coalesced with.
- */
-static int elevator_noop_merge(request_queue_t *q, struct request **req,
-			       struct bio *bio)
-{
-	int ret;
-
-	ret = elv_try_last_merge(q, bio);
-	if (ret != ELEVATOR_NO_MERGE)
-		*req = q->last_merge;
-
-	return ret;
-}
-
-static void elevator_noop_merge_requests(request_queue_t *q, struct request *req,
-					 struct request *next)
-{
-	list_del_init(&next->queuelist);
-}
-
 static void elevator_noop_add_request(request_queue_t *q, struct request *rq)
 {
 	elv_dispatch_insert(q, rq, 0);
-
-	/*
-	 * new merges must not precede this barrier
-	 */
-	if (rq->flags & REQ_HARDBARRIER)
-		q->last_merge = NULL;
-	else if (!q->last_merge)
-		q->last_merge = rq;
 }
 
 static int elevator_noop_dispatch(request_queue_t *q, int force)
@@ -48,8 +19,6 @@ static int elevator_noop_dispatch(reques
 
 static struct elevator_type elevator_noop = {
 	.ops = {
-		.elevator_merge_fn		= elevator_noop_merge,
-		.elevator_merge_req_fn		= elevator_noop_merge_requests,
 		.elevator_dispatch_fn		= elevator_noop_dispatch,
 		.elevator_add_req_fn		= elevator_noop_add_request,
 	},


  parent reply	other threads:[~2005-06-16  5:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-16  4:56 [PATCH Linux 2.6.12-rc6-mm1 00/06] blk: generic dispatch queue (for review) Tejun Heo
2005-06-16  4:56 ` [PATCH Linux 2.6.12-rc6-mm1 01/06] blk: implement generic dispatch queue Tejun Heo
2005-06-16  4:56 ` [PATCH Linux 2.6.12-rc6-mm1 02/06] blk: update noop iosched to use " Tejun Heo
2005-06-16  4:56 ` [PATCH Linux 2.6.12-rc6-mm1 03/06] blk: update cfq " Tejun Heo
2005-06-16  4:56 ` [PATCH Linux 2.6.12-rc6-mm1 04/06] blk: move last_merge handling into generic elevator code Tejun Heo
2005-06-16  4:57 ` Tejun Heo [this message]
2005-06-16  4:57 ` [PATCH Linux 2.6.12-rc6-mm1 06/06] blk: remove last_merge handling from cfq iosched Tejun Heo
2005-06-16  6:19 ` [PATCH Linux 2.6.12-rc6-mm1 00/06] blk: generic dispatch queue (for review) Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050616045540.947E3AD5@htj.dyndns.org \
    --to=htejun@gmail.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®