From: Andrew Morton <akpm@osdl.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: drummond@valinux.com, davidm@hpl.hp.com, eranian@hpl.hp.com,
linux-kernel@vger.kernel.org
Subject: Re: [resend][PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()
Date: Thu, 16 Jun 2005 13:41:26 -0700 [thread overview]
Message-ID: <20050616134126.264d6bd5.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0506162219040.2477@dragon.hyggekrogen.localhost>
Jesper Juhl <juhl-lkml@dif.dk> wrote:
>
> I send in the patch below a while back but never recieved any response.
> Now I'm resending it in the hope that it might be added to -mm.
There are surely many warnings in the tree, hence I'm not really interested
in patches which only fix `gcc -W' warnings.
How many are there?
> It looks to me like a significantly large 'len' passed in could cause the
> loop to never end. Isn't it safer to make 'i' an unsigned long as well?
Nope. All operations which mix signed and unsigned types promote the
signed type to unsigned.
next prev parent reply other threads:[~2005-06-16 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-16 20:21 Jesper Juhl
2005-06-16 20:41 ` Andrew Morton [this message]
2005-06-16 21:02 ` Jesper Juhl
2005-06-16 21:48 ` Arnd Bergmann
2005-06-16 22:24 ` Jesper Juhl
2005-06-16 20:45 ` Richard B. Johnson
2005-06-16 21:07 ` Jesper Juhl
2005-06-16 21:32 ` Arnd Bergmann
2005-06-16 21:01 ` David Mosberger
2005-06-20 17:00 ` Jesse Barnes
2005-06-17 0:25 Arnd Bergmann <arnd@arndb.de>
2005-06-17 17:04 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050616134126.264d6bd5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davidm@hpl.hp.com \
--cc=drummond@valinux.com \
--cc=eranian@hpl.hp.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®