mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitezslav Samel <samel@mail.cz>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	Bob Picco <bob.picco@hp.com>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: hpet patches
Date: Thu, 16 Jun 2005 16:00:57 +0200	[thread overview]
Message-ID: <20050616140057.GA20965@pc11.op.pod.cz> (raw)
In-Reply-To: <9e47339105061510547ea7d2f0@mail.gmail.com>

On Wed, Jun 15, 2005 at 01:54:16PM -0400, Jon Smirl wrote:
> On 6/15/05, Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com> wrote:
> > The specification for ICH5 has the details about this address
> > http://www.intel.com/design/chipsets/datashts/25251601.pdf (Chapter 17).
> > We need to look at specific device address to figure out the HPET base
> > address in this case.
> 
> The ICH5 fix up needs to look something like this:
> PCI_DEVICE_ID_INTEL_82801EB_0 is the PCI ID for the LPC device.
> 
> ACPI_FIXUP(INTEL, PCI_DEVICE_ID_INTEL_82801EB_0, hpet_ich5_fixup)
> hpet_ich5_fixup()
> {
>      pci_bios_find_device(PCI_ID_INTEL, PCI_DEVICE_ID_INTEL_82801EB_0, ...)
>      pci_bios_read(device, GENERAL_CONTROL_REGISTER, ..)
>      Check bit 17 and see if it is enabled
>      use bit 15:16 to set hpet_address to one of the four addresses
> }
> 
> It would be more complicated to try and turn it on if it is turned
> off. Mine is turned on at boot even though it has no ACPI entry.

  On our HP DL380g4 (ICH5 chipset) it is turned off. Could you, please,
try to turn it on in your patches? I'll be glad to test your patches.

	Thanks,
		Vita

  parent reply	other threads:[~2005-06-16 14:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15 17:15 Pallipadi, Venkatesh
2005-06-15 17:54 ` Jon Smirl
2005-06-15 18:11   ` Lee Revell
2005-06-16 14:00   ` Vitezslav Samel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-14 23:16 Pallipadi, Venkatesh
2005-06-14 23:36 ` Jon Smirl
2005-06-15  0:51   ` Andi Kleen
2005-06-14 22:37 Pallipadi, Venkatesh
2005-06-14 23:11 ` Jon Smirl
     [not found] <88056F38E9E48644A0F562A38C64FB6004F77C29@scsmsx403.amr.corp.intel.com>
     [not found] ` <9e473391050614092661d665ee@mail.gmail.com>
     [not found]   ` <20050614164605.GQ3728@localhost.localdomain>
2005-06-14 17:50     ` Jon Smirl
2005-06-14 18:38       ` Bob Picco
2005-06-14 21:51         ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050616140057.GA20965@pc11.op.pod.cz \
    --to=samel@mail.cz \
    --cc=akpm@osdl.org \
    --cc=bob.picco@hp.com \
    --cc=jonsmirl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®