From: Denis Vlasenko <vda@ilport.com.ua>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fealnx.c calls dev_kfree_skb from atomic context. fix it
Date: Fri, 17 Jun 2005 10:22:24 +0300 [thread overview]
Message-ID: <200506171022.24460.vda@ilport.com.ua> (raw)
[-- Attachment #1: Type: text/plain, Size: 66 bytes --]
Hi Jeff,
Just a resend. Applies with offset to 2.6.12-rc2
--
vda
[-- Attachment #2: fealnx_skbfree.patch --]
[-- Type: text/x-diff, Size: 696 bytes --]
I believe I actually saw 'Badness' message because I used
wrong function.
No need to check and use exactly matching function,
This is not a fast path.
diff -urN linux-2.6.6-bk7.src/drivers/net/fealnx.c linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c
--- linux-2.6.6-bk7.src/drivers/net/fealnx.c Thu May 20 21:38:05 2004
+++ linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c Thu May 20 21:43:31 2004
@@ -1435,8 +1435,7 @@
if (cur->skbuff) {
pci_unmap_single(np->pci_dev, cur->buffer,
cur->skbuff->len, PCI_DMA_TODEVICE);
- dev_kfree_skb(cur->skbuff);
- /* or dev_kfree_skb_irq(cur->skbuff); ? */
+ dev_kfree_skb_any(cur->skbuff);
cur->skbuff = NULL;
}
cur->status = 0;
reply other threads:[~2005-06-17 7:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506171022.24460.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®