mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Robert Love <rml@novell.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Zach Brown <zab@zabbo.net>,
	linux-kernel@vger.kernel.org,
	Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	John McCutchan <ttb@tentacle.dhs.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] inotify.
Date: Fri, 17 Jun 2005 19:28:26 +0100	[thread overview]
Message-ID: <20050617182826.GA20250@infradead.org> (raw)
In-Reply-To: <1119032213.3949.124.camel@betsy>

On Fri, Jun 17, 2005 at 02:16:53PM -0400, Robert Love wrote:
> We considered your feedback, Christoph.  Ultimately, John, Andrew, and I
> settled on the current approach.  In life, not everyone agrees on every
> little detail and there usually exists a large difference between "not
> exactly the same" and "horrible".  And never does the histrionics result
> in anything productive.

This shows exactly on how you're refusing feedback on the basis totally
unfounded claims again.

You are using ioctl as an really bad syscall multiplexer.  You're
not using the file descriptor it's called on at all, so it does not qualify
as a valid ioctl() usage even under the most lax rules.

Also you claimed the resource shortage for the proposed architecture
with just a single syscall, aka one watch per fd without showing any
reasons why that would be true, in fact by any means there's no reason
to believe file descriptors are a rare ressource in a modern Linux system.

I don't care whether you adopt my interface proposal or a different passable
one, but the current one is not acceptable at all.

  reply	other threads:[~2005-06-17 18:28 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-15 17:18 Robert Love
2005-06-16 17:52 ` Zach Brown
2005-06-16 18:25   ` Robert Love
2005-06-17  1:30     ` Nick Piggin
2005-06-17  1:35       ` Robert Love
2005-06-17 15:15         ` [patch] inotify, improved Robert Love
2005-06-17 15:37           ` Chris Friesen
2005-06-17 15:44             ` Robert Love
2005-06-17 16:11               ` Valdis.Kletnieks
2005-06-17 16:29                 ` Robert Love
2005-06-17 16:36                 ` Chris Friesen
2005-06-17 16:43                   ` Chris Wright
2005-06-17 16:46                   ` Muli Ben-Yehuda
2005-06-17 16:40               ` Chris Friesen
2005-06-17 17:57                 ` John McCutchan
2005-06-17 17:20           ` Zach Brown
2005-06-17 17:54             ` John McCutchan
2005-06-17 17:56               ` Zach Brown
2005-06-17 18:15                 ` John McCutchan
2005-06-17 18:17                   ` Zach Brown
2005-06-17 17:07     ` [patch] inotify Arnd Bergmann
2005-06-17 17:54       ` Christoph Hellwig
2005-06-17 18:12         ` John McCutchan
2005-06-17 18:16         ` Robert Love
2005-06-17 18:28           ` Christoph Hellwig [this message]
2005-06-17 18:38             ` Robert Love
2005-06-17 18:45               ` Christoph Hellwig
2005-06-17 18:54                 ` Robert Love
2005-06-17 17:56       ` John McCutchan
2005-06-17 21:33         ` Andrew Morton
2005-06-17 21:40           ` Robert Love
2005-06-17 23:52             ` Robert Love
2005-06-21  0:51               ` Neil Brown
2005-06-21  2:15                 ` John McCutchan
2005-06-21  2:29                   ` Neil Brown
2005-06-21  2:43                     ` John McCutchan
2005-06-21 15:55                     ` Robert Love
2005-07-14  0:25                       ` Neil Brown
2005-07-14  4:11                         ` John McCutchan
2005-06-18  0:05             ` Arnd Bergmann
2005-06-18  0:57               ` Robert Love
2005-06-18  1:51       ` Chris Wedgwood
  -- strict thread matches above, loose matches on Subject: below --
2005-05-09 16:05 Robert Love
2005-05-09 17:43 ` Coywolf Qi Hunt
2005-01-06 20:00 Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050617182826.GA20250@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    --cc=ttb@tentacle.dhs.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®