From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Pavel Machek <pavel@suse.cz>
Cc: domen@coderock.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] kernel/power/disk.c string fix and if-less iterator
Date: Tue, 21 Jun 2005 09:36:15 +0200 [thread overview]
Message-ID: <20050621073615.GF27887@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20050620221041.GI2222@elf.ucw.cz>
On Tue, 21 June 2005 00:10:41 +0200, Pavel Machek wrote:
>
> > The attached patch:
> >
> > o Fixes kernel/power/disk.c string declared as 'char *p = "...";' to be
> > declared as 'char p[] = "...";', as pointed by Jeff Garzik.
>
> ? Why was char *p ... wrong? Because you could not do sizeof() later?
Not necessarily wrong, but iirc, "*p" can waste 4 bytes (or 8, for
64-bit platforms). Since this variable isn't static, that's a
non-issue, but I've seen it on some kernel-janitor list anyway.
Jörn
--
Those who come seeking peace without a treaty are plotting.
-- Sun Tzu
next prev parent reply other threads:[~2005-06-21 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 21:57 domen
2005-06-20 22:10 ` Pavel Machek
2005-06-20 23:42 ` Andreas Schwab
2005-06-21 7:36 ` Jörn Engel [this message]
2005-06-21 9:07 ` Domen Puncer
2005-06-21 15:15 ` Horst von Brand
2005-06-21 7:33 ` Jörn Engel
2005-06-21 12:18 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050621073615.GF27887@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®