From: Pete Zaitcev <zaitcev@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: rostedt@goodmis.org, gregkh@suse.de, torvalds@osdl.org,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, zaitcev@redhat.com
Subject: Re: [RFC: 2.6 patch] better USB_MON dependencies
Date: Tue, 21 Jun 2005 12:35:07 -0700 [thread overview]
Message-ID: <20050621123507.6b83ddf0.zaitcev@redhat.com> (raw)
In-Reply-To: <20050621143227.GO3666@stusta.de>
On Tue, 21 Jun 2005 16:32:27 +0200, Adrian Bunk <bunk@stusta.de> wrote:
> The patch below tries to solve this in a better way.
> config USB_MON
> - tristate "USB Monitor"
> - depends on USB
> + bool "USB Monitor"
> + depends on USB!=n
> default y
This is a good idea and I wanted to do it for a while, only I was unable
to figure how to write the "depends on USB!=n" part. I'm all for it.
Let me give it a test here just to be sure, but I think we're good.
One question though, do we want this:
> -obj-$(CONFIG_USB_MON) += mon/
> +ifdef CONFIG_USB_MON
> + obj-$(CONFIG_USB) += mon/
> +endif
Seems superfluous to me, because we kept CONFIG_USB_MON. This place should
probably be left alone.
-- Pete
next prev parent reply other threads:[~2005-06-21 19:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-18 5:13 Linux 2.6.12 Linus Torvalds
2005-06-18 5:38 ` Keith Owens
2005-06-18 6:05 ` Linus Torvalds
2005-06-18 6:59 ` Willy Tarreau
2005-06-18 10:36 ` Jesper Juhl
2005-06-18 10:48 ` Alexey Dobriyan
2005-06-18 10:52 ` Jesper Juhl
2005-06-18 10:54 ` Brice Goglin
2005-06-18 17:42 ` Linus Torvalds
2005-06-18 18:26 ` Steven Rostedt
2005-06-21 14:32 ` [RFC: 2.6 patch] better USB_MON dependencies Adrian Bunk
2005-06-21 19:35 ` Pete Zaitcev [this message]
2005-06-21 21:04 ` Adrian Bunk
2005-06-23 9:36 ` [2.6 " Adrian Bunk
2005-06-25 20:15 ` Pete Zaitcev
2005-06-25 21:32 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050621123507.6b83ddf0.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome