From: Andrew Morton <akpm@osdl.org>
To: Stas Sergeev <stsp@aknet.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] spinlock cleanup
Date: Tue, 21 Jun 2005 20:36:24 -0700 [thread overview]
Message-ID: <20050621203624.0e2f48f9.akpm@osdl.org> (raw)
In-Reply-To: <42B8D9FF.1070000@aknet.ru>
Stas Sergeev <stsp@aknet.ru> wrote:
>
> Here is another attempt to
> remove the "extern i8253_lock"
> from the C files.
> It now uses the same #ifdefs for
> including the header and using
> the lock, so it hopefully no
> longer breaks the compilation.
> Does it look good this time?
Adding ifdefs around #includes is a bit unsightly - it also increases the
possibility that the build will break when .configs are changed.
Is it not possible to find an appropriate arch-specific header file for the
declaration?
next prev parent reply other threads:[~2005-06-22 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 3:24 Stas Sergeev
2005-06-22 3:36 ` Andrew Morton [this message]
2005-06-22 8:52 ` [patch] i8253-i8259A-lock-cleanup Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050621203624.0e2f48f9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®