mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "Lynch, Rusty" <rusty.lynch@intel.com>,
	"Ingo Molnar" <mingo@elte.hu>, "Andrew Morton" <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-ia64@vger.kernel.org>
Subject: RE: scheduler cache-hot-auto-tune patch breaks ia64 UP build
Date: Tue, 21 Jun 2005 15:51:36 -0700	[thread overview]
Message-ID: <200506212251.j5LMpag28920@unix-os.sc.intel.com> (raw)
In-Reply-To: <032EB457B9DBC540BFB1B7B519C78B0E076E3C6A@orsmsx404.amr.corp.intel.com>

Lynch, Rusty wrote on Tuesday, June 21, 2005 3:04 PM
> Attempting to build 2.6.12-mm1 on ia64 with CONFIG_SMP disabled will
> cause the build to break because max_cache_size is undefined.  I haven't
> spent the time to understand the cache-hot-auto-tune feature, so I don't
> have a patch to fix the problem.

It needs a #ifdef around max_cache_size.  Patch to fix the build problem.


Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>

--- linux-2.6.12/arch/ia64/kernel/setup.c.orig	2005-06-21 15:46:16.418636538 -0700
+++ linux-2.6.12/arch/ia64/kernel/setup.c	2005-06-21 15:46:34.496761317 -0700
@@ -655,7 +655,9 @@ get_max_cacheline_size (void)
 			cache_size = cci.pcci_cache_size;
         }
   out:
+#ifdef CONFIG_SMP
 	max_cache_size = max(max_cache_size, cache_size);
+#endif
 	if (max > ia64_max_cacheline_size)
 		ia64_max_cacheline_size = max;
 }


      reply	other threads:[~2005-06-21 22:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-21 22:03 Lynch, Rusty
2005-06-21 22:51 ` Chen, Kenneth W [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506212251.j5LMpag28920@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=akpm@osdl.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty.lynch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®