From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261554AbVFVQ3l (ORCPT ); Wed, 22 Jun 2005 12:29:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261653AbVFVQ1J (ORCPT ); Wed, 22 Jun 2005 12:27:09 -0400 Received: from mail.kroah.org ([69.55.234.183]:36549 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261554AbVFVQW1 (ORCPT ); Wed, 22 Jun 2005 12:22:27 -0400 Date: Wed, 22 Jun 2005 09:22:21 -0700 From: Greg KH To: Stelian Pop Cc: Alan Stern , linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [linux-usb-devel] Re: usb sysfs intf files no longer created when probe fails Message-ID: <20050622162221.GB2274@kroah.com> References: <1119455608.4651.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1119455608.4651.5.camel@localhost.localdomain> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 22, 2005 at 05:53:28PM +0200, Stelian Pop wrote: > Le mercredi 22 juin 2005 ?? 11:41 -0400, Alan Stern a ??crit : > > > This is a curious aspect of the driver model core. Should failure of a > > driver to bind be considered serious enough to cause device_add to fail? > > The current answer is Yes unless the driver's probe routine returns > > -ENODEV or -ENXIO, in which case the failure is not considered serious. > > Indeed. I've also tracked my problem down to the hid core which returns > -EIO when it fails to drive an unknown HID device, instead of a more > logical -ENODEV (this is not a failure to init a known device, but > rather the impossibility to init an unknown device). > > The patch below solves the problem for me: Damm, beat me by a few minutes :) Yes, this is the proper fix for this. But to answer Alan's main question, I think you are correct, we should not fail device_add if binding a device fails. I can see this causing a lot of very difficult problems in the future (including the fact that I've been hitting this bug with a new driver I'm writing and didn't even realize it...) So, I'll apply this one, and revert the main part of Hannes's patch too. Thanks for tracking this down. greg k-h