From: Coywolf Qi Hunt <coywolf@sosdg.org>
To: lkml@dervishd.net
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [question] pass CONFIG_FOO to CC problem
Date: Wed, 22 Jun 2005 21:04:45 -0500 [thread overview]
Message-ID: <20050623020445.GA19528@everest.sosdg.org> (raw)
In-Reply-To: <20050622181207.GC57@DervishD>
On Wed, Jun 22, 2005 at 08:12:07PM +0200, DervishD wrote:
> Hi Coywolf :)
>
> * Coywolf Qi Hunt <coywolf@gmail.com> dixit:
> > I was expecting kbuild passes CONFIG_FOO from .config to CC
> > -DCONFIG_FOO, but it doesn't. So I have to add
> >
> > ifdef CONFIG_FOO
> > EXTRA_CFLAGS += -DCONFIG_FOO
> > endif
>
> NO! You don't do it that way in the kernel. Think: if you have to
> pass a '-D' option for each config item you set, you will end up with
> TONS of '-D' options, in fact you probably exceed the command line
> size limit.
I see. It's not only ugly, but also harmful.
>
> You have to include <linux/config.h> if I recall correctly ;)
>
<linux/config.h> is for this purpose, if I understand correctly.
Coywolf
prev parent reply other threads:[~2005-06-23 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 8:39 Coywolf Qi Hunt
2005-06-22 9:54 ` Ian Campbell
2005-06-22 10:11 ` Coywolf Qi Hunt
2005-06-22 18:12 ` DervishD
2005-06-23 2:04 ` Coywolf Qi Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050623020445.GA19528@everest.sosdg.org \
--to=coywolf@sosdg.org \
--cc=coywolf@lovecn.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@dervishd.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®