From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262898AbVFWUBL (ORCPT ); Thu, 23 Jun 2005 16:01:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262911AbVFWTyA (ORCPT ); Thu, 23 Jun 2005 15:54:00 -0400 Received: from gate.ebshome.net ([64.81.67.12]:15562 "EHLO gate.ebshome.net") by vger.kernel.org with ESMTP id S262694AbVFWTtE (ORCPT ); Thu, 23 Jun 2005 15:49:04 -0400 Date: Thu, 23 Jun 2005 12:48:56 -0700 From: Eugene Surovegin To: Marcelo Tosatti Cc: Andrei Konovalov , akpm@osdl.org, trini@kernel.crashing.org, linux-kernel@vger.kernel.org, yshpilevsky@ru.mvista.com, linuxppc-embedded@ozlabs.org Subject: Re: [PATCH] ppc32: add Freescale MPC885ADS board support Message-ID: <20050623194856.GA4588@gate.ebshome.net> Mail-Followup-To: Marcelo Tosatti , Andrei Konovalov , akpm@osdl.org, trini@kernel.crashing.org, linux-kernel@vger.kernel.org, yshpilevsky@ru.mvista.com, linuxppc-embedded@ozlabs.org References: <42BAD78E.1020801@ru.mvista.com> <20050623140522.GA25724@logos.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050623140522.GA25724@logos.cnet> X-ICQ-UIN: 1193073 X-Operating-System: Linux i686 X-PGP-Key: http://www.ebshome.net/pubkey.asc User-Agent: Mutt/1.5.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 23, 2005 at 11:05:22AM -0300, Marcelo Tosatti wrote: > > Hi Andrei, > > On Thu, Jun 23, 2005 at 07:38:54PM +0400, Andrei Konovalov wrote: > > > > diff --git a/arch/ppc/syslib/m8xx_setup.c b/arch/ppc/syslib/m8xx_setup.c > > --- a/arch/ppc/syslib/m8xx_setup.c > > +++ b/arch/ppc/syslib/m8xx_setup.c > > @@ -369,7 +369,7 @@ m8xx_map_io(void) > > #if defined(CONFIG_HTDMSOUND) || defined(CONFIG_RPXTOUCH) || defined(CONFIG_FB_RPX) > > io_block_mapping(HIOX_CSR_ADDR, HIOX_CSR_ADDR, HIOX_CSR_SIZE, _PAGE_IO); > > #endif > > -#ifdef CONFIG_FADS > > +#if defined(CONFIG_FADS) || defined(CONFIG_MPC885ADS) > > io_block_mapping(BCSR_ADDR, BCSR_ADDR, BCSR_SIZE, _PAGE_IO); > > #endif > > #ifdef CONFIG_PCI > > I suppose you also want to include CONFIG_MPC885ADS in the io_block_mapping(IO_BASE) > here? I think it'd be great if we _stop_ adding new io_block_mapping users, there is ioremap() for stuff like this, let's use it instead. -- Eugene